Skip to content

Use tanstack query for api requests #14

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2026
Merged

Use tanstack query for api requests #14

merged 5 commits into from
Sep 16, 2026
+83 −55

Conversation

minael
Copy link
Member

@minael minael commented Sep 15, 2026 •
edited
Loading

Replace the previous API fetching with TanStack Query for character and episode data. Episode requests are also grouped to reduce unnecessary API calls.

Closes #13

@minael minael added this to the P1 milestone Sep 15, 2026
@minael minael requested review from karenska and emmafre September 15, 2026 15:43
@minael minael self-assigned this Sep 15, 2026
@minael minael requested a review from a team as a code owner September 15, 2026 15:43
karenska
karenska approved these changes Sep 15, 2026
View reviewed changes
Copy link
Member

@karenska karenska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks nice

emmafre
emmafre reviewed Sep 16, 2026
View reviewed changes
Copy link
Member

@emmafre emmafre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes you made with the API and the use of React Query! However, I don't think <CharactersPage /> should be moved under HomePage. Since it's a separate page, I think it would make more sense to render it from App instead.

@minael minael force-pushed the 13-use-tanstack-query-for-api-requests branch from 12cc78f to 0122a47 Compare September 16, 2026 12:45
@minael
Copy link
Member Author

minael commented Sep 16, 2026

Thanks! I moved CharactersPage to App instead.

@minael minael requested a review from emmafre September 16, 2026 12:56
emmafre
emmafre approved these changes Sep 16, 2026
View reviewed changes
Copy link
Member

@emmafre emmafre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Ready for merge

@emmafre emmafre linked an issue Sep 16, 2026 that may be closed by this pull request
Use TanStack Query for API requests #13
Closed
3 tasks
@emmafre emmafre changed the title 13 use tanstack query for api requests Use tanstack query for api requests Sep 16, 2026
@minael minael merged commit e7c7457 into dev Sep 16, 2026
@emmafre emmafre deleted the 13-use-tanstack-query-for-api-requests branch September 18, 2026 07:20
Sign in to join this conversation on GitHub.
Reviewers

@karenska karenska karenska approved these changes

@emmafre emmafre emmafre approved these changes

Assignees

@minael minael

Labels
None yet
Projects
None yet
Milestone
P1
Development

Successfully merging this pull request may close these issues.

Use TanStack Query for API requests
3 participants
@minael @karenska @emmafre